Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaindb: add trigger to force rollback the tree for reorgs #248

Closed
wants to merge 1 commit into from

Conversation

kilpatty
Copy link
Contributor

@kilpatty kilpatty commented Sep 10, 2019

May or may not be the best way to fix this, just pushing to start some discussion

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #248 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   53.11%   53.12%   +<.01%     
==========================================
  Files         129      129              
  Lines       35748    35748              
  Branches     6022     6023       +1     
==========================================
+ Hits        18989    18991       +2     
+ Misses      16759    16757       -2
Impacted Files Coverage Δ
lib/blockchain/chaindb.js 63.73% <100%> (ø) ⬆️
lib/script/script.js 59.4% <0%> (+0.08%) ⬆️
lib/utils/binary.js 58.97% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc35dc2...450a2c6. Read the comment docs.

@kilpatty
Copy link
Contributor Author

This is definitely not a good solution, and it looks like the real fix might be even simpler so just going to close this.

@kilpatty kilpatty closed this Sep 10, 2019
chjj added a commit that referenced this pull request Sep 11, 2019
@kilpatty
Copy link
Contributor Author

ping @boymanjor to merge these into testnet4-stable if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants