-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet: fix change lookahed address #413
Conversation
change address will not be saved if call hsw-cli change
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
==========================================
- Coverage 61.69% 61.68% -0.01%
==========================================
Files 129 129
Lines 34824 34824
Branches 5916 5916
==========================================
- Hits 21484 21482 -2
- Misses 13340 13342 +2
Continue to review full report at Codecov.
|
Thank you. Can you please just include the module name with your commit message:
|
@qimiaoguo, thank you for finding this. A patch update was just published. I think we should consider a migration path for affected wallets. I think a simple migration would be to regenerate and save all change addresses in the lookahead. The user will most likely have to rescan after that (whether to do this automatically or require user intervention is something I'm unsure of). |
change address will not be saved if call hsw-cli change