Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: fix change lookahed address #413

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

qimiaoguo
Copy link
Contributor

change address will not be saved if call hsw-cli change

change address will not be saved if call hsw-cli change
@codecov-io
Copy link

Codecov Report

Merging #413 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   61.69%   61.68%   -0.01%     
==========================================
  Files         129      129              
  Lines       34824    34824              
  Branches     5916     5916              
==========================================
- Hits        21484    21482       -2     
- Misses      13340    13342       +2     
Impacted Files Coverage Δ
lib/wallet/account.js 76.09% <100.00%> (ø)
lib/covenants/rules.js 73.04% <0.00%> (-0.15%) ⬇️
lib/script/script.js 59.32% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e0b83...143a283. Read the comment docs.

@qimiaoguo
Copy link
Contributor Author

@pinheadmz
Copy link
Member

pinheadmz commented Mar 31, 2020

Thank you. Can you please just include the module name with your commit message:

wallet: fix change lookahead address

@qimiaoguo qimiaoguo changed the title Update account.js wallet: fix change lookahed address Mar 31, 2020
@chjj chjj merged commit 75b8d06 into handshake-org:master Mar 31, 2020
@chjj
Copy link
Contributor

chjj commented Mar 31, 2020

@qimiaoguo, thank you for finding this. A patch update was just published.

I think we should consider a migration path for affected wallets. I think a simple migration would be to regenerate and save all change addresses in the lookahead. The user will most likely have to rescan after that (whether to do this automatically or require user intervention is something I'm unsure of).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants