Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns/server: return KEY rr #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Aug 7, 2020

This PR returns a KEY resource record containing the SIG(0) key. This is useful for integrating with systems that expect to be able to validate SIG(0) and automatically look for a KEY rr. This is an alternative to #299 and is meant to make applications like https://github.com/james-stevens/handshake-bridge more simple to put together.

@coveralls
Copy link

coveralls commented Aug 7, 2020

Pull Request Test Coverage Report for Build 203068515

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 58.98%

Files with Coverage Reduction New Missed Lines %
lib/protocol/consensus.js 1 82.79%
Totals Coverage Status
Change from base Build 202553015: 0.005%
Covered Lines: 19289
Relevant Lines: 30410

💛 - Coveralls

@tynes tynes requested a review from pinheadmz August 10, 2020 20:53
@pinheadmz pinheadmz added this to the v2.4.0 milestone Jan 18, 2021
@nodech nodech added dns part of the codebase needs tests modifier feature general - adding feature breaking-minor Backwards compatible - Release version needs rebase modifier labels Dec 10, 2021
@pinheadmz pinheadmz removed this from the v2.5.0 milestone Feb 8, 2022
@pinheadmz pinheadmz removed their request for review July 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-minor Backwards compatible - Release version dns part of the codebase feature general - adding feature needs rebase modifier needs tests modifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants