Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407
...but in a lazy way that more kicks the can down the road than anything.
See this comment specifically for details.
TODO:
Update:
This was lowered from 1000 to 200 because in the serialized account metadata, the lookahead value is only a single byte:
hsd/lib/wallet/account.js
Line 747 in 7826128
benchmarks:
master branch
account: ops=1000, time=3.276540621, rate=305.19994
PR branch
account: ops=1000, time=46.609575762, rate=21.45482
No big surprise there - creating an account makes generating 20x more keys (380 total because of receive & change).
So we've increased account creation time from ~3ms to ~46ms