Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: propagate the user agent from node to pool #710

Merged
merged 2 commits into from
Apr 24, 2022
Merged

net: propagate the user agent from node to pool #710

merged 2 commits into from
Apr 24, 2022

Conversation

pinheadmz
Copy link
Member

@pinheadmz pinheadmz commented Apr 11, 2022 •
edited
Loading

Closes #664

TODO:

  • Add comment to CHANGELOG ?

@pinheadmz pinheadmz mentioned this pull request Apr 11, 2022
Closed
rithvikvibhu
rithvikvibhu approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agent is set correctly (and is simpler than agent, agentComment)

@Falci Falci mentioned this pull request Apr 18, 2022
Merged
nodech
nodech approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@nodech nodech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/node/spvnode.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 24, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 64.593% when pulling 48c6aa7 on pinheadmz:agent2 into 35ea46d on handshake-org:master.

nodech
nodech approved these changes Apr 24, 2022
View reviewed changes
test/net-test.js Outdated Show resolved Hide resolved
test/net-test.js Outdated Show resolved Hide resolved
pinheadmz and others added 2 commits April 24, 2022 11:24
@pinheadmz @Falci
net: propagate the user agent from node to pool
36060ee 
Co-authored-by: Fernando Falci <fernando.falci@adevinta.com>
@pinheadmz
pkg: update CHANGELOG
48c6aa7
@pinheadmz pinheadmz merged commit e77546c into handshake-org:master Apr 24, 2022
@nodech nodech added the patch Release version label Jun 10, 2022
@rithvikvibhu rithvikvibhu mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithvikvibhu rithvikvibhu rithvikvibhu approved these changes

@nodech nodech nodech approved these changes

@Falci Falci Falci approved these changes

Assignees
No one assigned
Labels
patch Release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pinheadmz @coveralls @Falci @nodech @rithvikvibhu