-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix c_str redesign errors #10
Conversation
The `c_str` module has been redesigned: rust-lang/rust#20507 This change fixes the code to align with the redesign. Fixes hannobraun#9
The [Rust guideline](http://aturon.github.io/style/whitespace.html) stipulates that Rust source code should: > "Use 4 spaces for indentation, *not* tabs."
Aside from the The offset seems to be used for the name of the file that's changed. None of the automated tests cover this functionality. I think the best solution would be to add a test for this, so we can be sure the code was right. As before, I will get to it on Monday, or you can take a look, if you want. Thanks again for all your work! |
Regarding the unstable warnings, I've opened a separate issue: #11. |
@hannobraun yeah, the offset thing should be checked before this is merged, but I won't have time to do it this weekend :/ and no problem! |
@dead10ck Ok, I'll pick it up on Monday then :) |
Merged manually. The Thanks again, @dead10ck, for the great work! |
Ahh, I see. Sorry, I'm still new to Rust, and I haven't worked with lower-level FFI stuff yet, so I wasn't familiar with how all of that worked. I'm glad I was able to help with the other stuff though :) |
No need to apologize, that part of the code is a bit icky. We have a test for it now, so this problem shouldn't come up any more. |
c_str
redesign.int
/uint
have been renamed toisize
/usize