[#23] apply Detail page #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
hyesungoh
approved these changes
May 30, 2022
| `; | ||
|
|
||
| const ulWrapper = css` | ||
| all: unset; |
| width: 100%; | ||
| overflow-x: scroll; | ||
|
|
||
| ::-webkit-scrollbar { |
There was a problem hiding this comment.
Suggested change
| ::-webkit-scrollbar { | |
| &::-webkit-scrollbar { |
요런 형식으로 되어야 적용되지 않을까요?!
| </div> | ||
| <div css={imgWrapper}> | ||
| <Image | ||
| src="/images/menu.jpg" |
There was a problem hiding this comment.
이미지의 public path의 경우 상수로써 관리하는게 어떨까 생각해요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
Detail page를 개발하였습니다.
각 식당마다 정보가 잘못되거나 수정할 부분이 있을 수 있어 ChangeInform page를 만들어 제보할 수 있도록 하였습니다.
지도, 공유 버튼은 개발 후 적용할 계획입니당
중점적으로 봐줬으면 좋을 부분