[#18] apply kakao map api #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
hyesungoh
reviewed
Jul 28, 2022
hyesungoh
approved these changes
Jul 28, 2022
src/assets/stores/position.ts
Outdated
| lng: number; | ||
| } | ||
|
|
||
| export const positions: IPosition[] = [ |
There was a problem hiding this comment.
이런 상수의 경우 as const, const assertion 이라 불리는 문법을 적용해 readonly로 관리하는 게 더 안전할 거 같아요 ~~
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#const-assertions
Comment on lines
62
to
67
| const itemInWrapper = (theme: Theme) => css` | ||
| const itemInWrapper = css` | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-around; | ||
| `; No newline at end of file | ||
| `; |
Comment on lines
+61
to
+71
| function makeOverListener(map, marker, infowindow) { | ||
| return function () { | ||
| infowindow.open(map, marker); | ||
| }; | ||
| } | ||
|
|
||
| function makeOutListener(infowindow) { | ||
| return function () { | ||
| infowindow.close(); | ||
| }; | ||
| } |
There was a problem hiding this comment.
여기서 함수가 함수를 반환하는 이유가 뭔가요 ??
Suggested change
| function makeOverListener(map, marker, infowindow) { | |
| return function () { | |
| infowindow.open(map, marker); | |
| }; | |
| } | |
| function makeOutListener(infowindow) { | |
| return function () { | |
| infowindow.close(); | |
| }; | |
| } | |
| function makeOutListener(infowindow) { | |
| infowindow.close(); | |
| } |
아래 함수만 예를 든다면 이렇게 작성해도 동일하게 동작할 것 같아서요!
There was a problem hiding this comment.
아래 링크와 같은 오류로 인해 다음과 같이 작성했습니다!
https://devtalk.kakao.com/t/kakao-tunneling-js-call-property/48483/2
https://apis.map.kakao.com/web/sample/multipleMarkerEvent/
There was a problem hiding this comment.
아하 이벤트 콜백이 실행되는 것이라, 클로저를 이용한 것이군요 !!
좋은 정보 잘봤습니다 ~~~ 👍 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
kakao map api 를 이용해 map page를 개발하였습니다.
중점적으로 봐줬으면 좋을 부분
kakao map api를 불러오기 위해 script를 사용하려 하였지만 해결하지 못해 우선 useEffect로 스크립트 불러왔습니다 ..🤯
마커 hover시 나타나는 content에 스타일을 주기 위해 style=""로 작성하였습니다.
그리고 길찾기 혹은 더 세부적인 지도 기능이 페이지에 필요할 지 고민입니다. 😬