Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak when unregistering most recently opened file handle. #27

Closed
wants to merge 1 commit into from

Conversation

logan
Copy link

@logan logan commented Jul 10, 2014

No description provided.

@hanwen
Copy link
Owner

hanwen commented Jul 11, 2014

The fix looks good, but I'm seeing hangs in go-fuse/fuse/test.TestMountRename

do the tests pass for you?

@logan
Copy link
Author

logan commented Jul 11, 2014

Yes, the tests all pass for me and I haven't encountered any hangs at all. I'm running go 1.3 on Ubuntu 13.10 (64-bit). Where are you seeing the test hang?

@hanwen
Copy link
Owner

hanwen commented Jul 13, 2014

I debugged into it. It's a separate issue. I'll merge your patch on monday.

On Fri, Jul 11, 2014 at 6:59 PM, Logan Hanks notifications@github.com
wrote:

Yes, the tests all pass for me and I haven't encountered any hangs at all.
I'm running go 1.3 on Ubuntu 13.10 (64-bit). Where are you seeing the test
hang?


Reply to this email directly or view it on GitHub
#27 (comment).

Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

@hanwen
Copy link
Owner

hanwen commented Jul 16, 2014

this is now pushed. thanks!

On Sun, Jul 13, 2014 at 1:32 PM, Han-Wen Nienhuys hanwenn@gmail.com wrote:

I debugged into it. It's a separate issue. I'll merge your patch on monday.

On Fri, Jul 11, 2014 at 6:59 PM, Logan Hanks notifications@github.com
wrote:

Yes, the tests all pass for me and I haven't encountered any hangs at
all. I'm running go 1.3 on Ubuntu 13.10 (64-bit). Where are you seeing the
test hang?


Reply to this email directly or view it on GitHub
#27 (comment).

Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants