Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature : Advance notice skip #84

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

etherfun
Copy link
Contributor

@etherfun etherfun commented Nov 18, 2024

  • 我同意我的所有贡献将以GPL-3.0协议开源。

#53 添加跳过前通知 提前时间为 '空降提醒弹窗'显示持续时间 设置时间
经测试赞助广告无偿推广可用 其他兼容性不明 (其实是找不到对应的片段了
已全部适配
(题外话:要不在服务器拿点片段 放在贡献指南里开发用 无偿推广这种都挺少的

效果预览

2024-11-18.202316.mp4

@xiaoxuan010
Copy link
Contributor

xiaoxuan010 commented Nov 18, 2024

感觉可以在跳过完成后把赞助广告 准备跳过更改为赞助广告 已跳过,不知道方不方便实现。

@etherfun
Copy link
Contributor Author

etherfun commented Nov 18, 2024

它那是固定的关键字 我也不知道
正常情况下这个是刚好在跳过时消失
靠后面的状态也可以判断跳过状态吧取消跳过 重新跳过

@xiaoxuan010
Copy link
Contributor

(题外话:要不在服务器拿点片段 放在贡献指南里开发用 "无偿推广"这种都挺少的

项目官网 可以下载到数据库,例如这个视频 BV1fKewejE29 ,包含了开场动画、赞助广告、离题、鸣谢/结束画面等类别,可以用来测试。

@@ -371,11 +371,11 @@
"description": "Used for skipping to things (Skip to Highlight)"
},
"skipped": {
"message": "{0} Skipped",
"message": "{0} Ready Skipped",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en.message.json 文件其实不需要更新,这个文件是用来追踪原插件的文本,每次合并原插件版本的时候才更新一次

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同目录下的message.json 也不需要吗?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message.json是需要的,en.message.json不需要,不过问题不大,因为下次同步会覆盖的

@hanydd hanydd linked an issue Nov 20, 2024 that may be closed by this pull request
@hanydd hanydd self-requested a review November 20, 2024 04:49
@hanydd
Copy link
Owner

hanydd commented Nov 20, 2024

整了个测试视频 https://www.bilibili.com/video/BV14741127BN/

Fix unskip bug and skip when paused bug
@etherfun etherfun marked this pull request as draft November 21, 2024 03:03
@etherfun etherfun marked this pull request as ready for review November 21, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

自动跳过提示框提前出现
3 participants