Update to hapi-fhir 6.5.20-SNAPSHOT #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
497 - Fix typo on property setter
lukedegruchy
approved these changes
May 17, 2023
|
|
||
| ourClient.create().resource(topic).execute(); | ||
|
|
||
| waitForSize(1, () -> ourClient.search().forResource(SubscriptionTopic.class).where(Subscription.STATUS.exactly().code("active")).cacheControl(new CacheControlDirective().setNoCache(true)).returnBundle(Bundle.class).execute().getEntry().size()); |
There was a problem hiding this comment.
Nitpick: This is long and a bit hard to read without scrolling. I suggest breaking this down to one line per method call
| @@ -99,7 +114,8 @@ public void testWebsocketSubscription() throws Exception { | |||
| SocketImplementation mySocketImplementation = new SocketImplementation(mySubscriptionId.getIdPart(), EncodingEnum.JSON); | |||
|
|
|||
| myWebSocketClient.start(); | |||
| URI echoUri = new URI("ws://localhost:" + port + "/websocket"); | |||
|
|
|||
| URI echoUri = new URI(endpoint); | |||
There was a problem hiding this comment.
General comment: It seems our formatting (tabs) conflcts with jpa-serverstarter's formatting (spaces). It looks like your changes use tabs.
There was a problem hiding this comment.
I think the lines with spaces are cruft from previous commits:
https://github.com/hapifhir/hapi-fhir-jpaserver-starter/blob/master/.editorconfig
My IntelliJ is picking .editorconfig up, and auto-formatting with tabs. I'm going to leave this alone for this PR so that the changes are clear-cut, but might do a reformat for this in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following in order to get all tests running (smoke tests included)