update for node 14 support #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloydbenson
approved these changes
Jul 24, 2020
Marsup
approved these changes
Jul 24, 2020
Nargonath
approved these changes
Jul 24, 2020
| Code.expect(1).to.equal(2); | ||
| } | ||
| catch (err) { | ||
| var exception = err; |
There was a problem hiding this comment.
I wouldn't use var and rather declare a let variable next to captureStackTrace but it's just nitpicking.
There was a problem hiding this comment.
That's part of hapi's custom ESLint setup. It's used in other places in this file, and across other hapi modules.
There was a problem hiding this comment.
Alright, my bad. I didn't know about this rule. I didn't check in the file if it was a recurrent pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking this as a work in progress because one line of code (lib/index.js line 138) is missing coverage.
If anyone wants to write a test for that line, contributions are very welcome.