Fix UnhandledPromiseRejection warning when logging on an ignored path #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few days ago I ran into a bug where logging via
request.log
would cause unhandled promise rejection warnings on routes with disabled logging. I traced it down to this line. Basically on an ignored route,current
is equal to thenullLogger
which doesn't have alevels
property.Steps to reproduce
request.log([level])
statement within a route handler such thatlevel
is a valid log level configured within hapi-pino such as 'info', 'warn', 'error', etc.ignorePaths
I've added a unit test which reproduces this bug.