Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add options.logRequestComplete, allow function syntax for options.logRequestStart #90

Merged

Conversation

BlooJeans
Copy link
Contributor

Stacked on top of #89 for formatting improvements to the README

This PR:

  • adds the ability to specify the existing options.logRequestStart using a function syntax: (Request) => boolean, which selectively enables/disables the logging on requestStart for the given request

  • adds the same functionality for the "request complete" event, letting you pass in either a boolean or a function of the same style.

  • keeps the current behavior / defaults, namely:

    • request start events are not logged
    • request completed events are logged

@BlooJeans BlooJeans changed the title Feat log request start log request complete Feat: add options.logRequestComplete, allow function syntax for options.logRequestStart Oct 28, 2019
@coveralls
Copy link

coveralls commented Oct 28, 2019

Coverage Status

Coverage increased (+0.1%) to 99.161% when pulling cda5cd8 on devshackio:feat-logRequestStart-logRequestComplete into 890b79e on pinojs:master.

@mcollina
Copy link
Collaborator

Would you mind to rebase against master? It currently has a conflict.

@BlooJeans BlooJeans force-pushed the feat-logRequestStart-logRequestComplete branch from bbdb9b9 to 7b42d74 Compare October 29, 2019 13:26
@BlooJeans
Copy link
Contributor Author

Would you mind to rebase against master? It currently has a conflict.

Rebased

@mcollina mcollina merged commit e947ac5 into hapijs:master Feb 6, 2020
@BlooJeans BlooJeans deleted the feat-logRequestStart-logRequestComplete branch February 6, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants