Handle thrown error from res.setHeader() and res.writeHead() #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @hueniverse any updates when this pull request will be merged? |
|
Probably another week or so. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
res.writeHead()is changed in Node@6 (and possibly node@4.4.5) so that it can throw aRangeErrorfor certain statusCodes, see nodejs/node#6291. When this throws, hapi will log an internal error without sending a response.This PR adds a
try/catchto catch this error and respond with a500to the client instead.Additionally, it will catch thrown errors from
res.setHeader(), eg. for an empty string header, and respond as above.