Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introspect flaky OSX lsof test #159

Closed
wants to merge 3 commits into from
Closed

Introspect flaky OSX lsof test #159

wants to merge 3 commits into from

Conversation

devinivy
Copy link
Member

Don't merge, just poking and prodding at a flaky test.

@devinivy devinivy marked this pull request as ready for review August 27, 2021 14:33
@devinivy
Copy link
Member Author

Turns out it was a race condition: once hapi calls close() on the file stream it takes some time for that to actually complete. I was able to fix it by waiting for the 'close' event on the stream if it wasn't already closed. I am going to port this change over to #158.

@devinivy devinivy closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devinivy