Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidirectional describe() <-> build() #1867

Closed
hueniverse opened this issue Jun 9, 2019 · 0 comments
Closed

Bidirectional describe() <-> build() #1867

hueniverse opened this issue Jun 9, 2019 · 0 comments
Assignees
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Milestone

Comments

@hueniverse
Copy link
Contributor

hueniverse commented Jun 9, 2019

Construct a schema using the description format.

Flags:

  • default, failover - plain value changed from value to { value }, function changes to direct reference without description.
  • allowUnknown -> unknown
  • allowOnly -> only

Options:

  • Changed options to preferences

Types:

  • lazy once flag moved to root
  • object shallow flag removed from describe()
  • alternatives wraps 'schema' matches item, rename alternatives to matches
  • boolean remove true false from default list of truthy/falsy
  • change symbol error string format
  • object patterns regex value changed to { regex }
  • change ref description (remove key, add all other properties when not the default, change ref to type and wrap in { ref } when object key is not ref).
  • Move description, label, and unit to flags
  • Renamed children to keys
  • Change string.regex to string.pattern and change arg to { pattern, options }
  • array unique arguments changed to original args
  • object instanceof arguments changed to original args

Valids / Invalids:

  • nun-null objects changed from value to { value }
  • rename valids to allow and invalids to invalid
  • only included if different from type default

Tests:

  • arg changed to args
  • single argument always include argument name

Misc:

  • meta -> metas
@hueniverse hueniverse added feature New functionality or improvement breaking changes Change that can breaking existing code labels Jun 9, 2019
@hueniverse hueniverse added this to the 16.0.0 milestone Jun 9, 2019
@hueniverse hueniverse self-assigned this Jun 9, 2019
hueniverse added a commit that referenced this issue Jul 2, 2019
hueniverse added a commit that referenced this issue Jul 4, 2019
hueniverse added a commit that referenced this issue Jul 12, 2019
hueniverse added a commit that referenced this issue Jul 22, 2019
hueniverse added a commit that referenced this issue Jul 22, 2019
hueniverse added a commit that referenced this issue Jul 22, 2019
hueniverse added a commit that referenced this issue Jul 23, 2019
@hueniverse hueniverse added the v16 label Aug 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

1 participant