Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair test suite for node v16 autoDestroy and coverage change #293

Merged
merged 3 commits into from
Mar 14, 2022

Conversation

devinivy
Copy link
Member

@devinivy devinivy commented Mar 14, 2022

The test suite needed a little love. Here are the changes:

  • As of node v16 autoDestroy is on streams. This broke a test where we try to emulate a stream without a destroy() method. See stream: autoDestroy: true nodejs/node#30625.
  • There were some coverage changes causing boolean expression branches to become stricter. Anyone know where that came from? I changed the code to remove the branches, each roughly of the form x === undefined || x === null to [null, undefined].includes(x).
  • I came across one timing-dependent flaky test and just made it run longer to make it less likely to flake out on e.g. a busy event loop.
  • Make test suite aware of win22 in addition to win19.

lib/index.js Outdated Show resolved Hide resolved
@devinivy devinivy merged commit fb6f87c into master Mar 14, 2022
@devinivy devinivy deleted the fix-test-suite branch March 14, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants