Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute preload query before HTML DoReplacesAsync & Add HTML only check for GetRenderedTemplateAsync #787

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

HappySven
Copy link
Contributor

Describe your changes

Execute preload query before HTML DoReplacesAsync & Add HTML only check for GetRenderedTemplateAsync.

  • Fixes bug in which the GCL also does replacements on JS, which it shouldnt.
  • Fixes GCL templates caching bug in which pre load queries got executed after the doReplacesAsync which caused unresolved template variables

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

Tested an HTML template in a local project that uses a preload query, making it accessible both within the template and on dynamic content pages referencing the template variable.

Additionally, tested a local configurator project, which now opens successfully after being able to resolve the template variables.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

none

Link to Asana ticket

https://app.asana.com/0/1205090868730163/1209339034569767
https://app.asana.com/0/1205090868730163/1203021850171653

@GilianJuice GilianJuice merged commit b50b40b into develop Feb 19, 2025
1 check passed
@GilianJuice GilianJuice deleted the bugfix/pre-load-query-caching-bug branch February 19, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants