non-working merge if ntsc transformer code

happycube · Jul 24, 2024 · d31232c · d31232c
2 parents a7d0f37 + 2ed2b3c
commit d31232c
Show file tree

Hide file tree

Showing 296 changed files with 19,338 additions and 23,507 deletions.
diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.md b/.github/ISSUE_TEMPLATE/BUG_REPORT.md
@@ -0,0 +1,67 @@
+---
+name: '🐞 Bug Report'
+about: Create a report to help us improve
+title: ''
+labels: ['bug']
+assignees: ''
+---
+
+### Checklist
+
+<!--
+✅ Please make sure that you have completed the following steps before submitting the bug report:
+-->
+
+- [ ] I have searched the issues page for any duplicate issues open or closed and confirmed that this bug has not been reported before.
+- [ ] I have tested the issue with the current build.
+- [ ] I have attached log files, uploaded sample data, and commands used so that the issue can be easily reproduced by the developers.
+
+
+### Bug Description
+
+<!--
+Please provide a clear and concise description of the bug you encountered.
+-->
+
+### Steps to Reproduce
+
+<!--
+Outline the steps to reproduce the bug:
+-->
+
+1. ...
+2. ...
+3. ...
+
+### Expected Behaviour
+
+<!--
+Explain what you expected to happen when performing the steps above.
+-->
+
+### Actual Behaviour
+
+<!--
+Explain what actually happened when performing the steps above. Include any error messages or unexpected behaviour.
+-->
+
+### Environment
+
+<!--
+Include information on your environment.
+-->
+
+- Decode version: [e.g., 1.2.3]
+- Operating System: [e.g., Windows 10, macOS Big Sur, Linux Ubuntu]
+- Hardware Used: [e.g., Ryzen 7 7950x, 16GB DDDR5-4400mhz, SSD NVME Gen 3 etc]
+
+### Additional Information
+
+<!--
+Include any additional information that might be relevant to the bug report, such as screenshots or related issues/Pull-Requests.
+-->
+
+### Is it related to tbc-video-export?
+
+<!-- if so visit its repo here https://github.com/JuniorIsAJitterbug/tbc-video-export/issues."
+-->
diff --git a/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md b/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.md
@@ -0,0 +1,44 @@
+---
+name: '🚀 Feature request'
+about: Suggest an idea for improving ld-decode, vhs-decode, hifi-decode, cvbs-decode or tbc-video-export
+title: ''
+labels: 'enhancement'
+assignees: ''
+---
+
+### Is your proposal related to a problem?
+
+<!--
+  Provide a clear and concise description of what the problem is.
+  For example, "I'm always frustrated when..."
+-->
+
+### Is your proposal already in the issue tickets?
+
+<!--
+  Please check https://github.com/happycube/ld-decode & https://github.com/oyvindln/vhs-decode/issues"
+-->
+
+### Is your proposal related to tbc-video-export?
+
+<!-- if so visit its repo here https://github.com/JuniorIsAJitterbug/tbc-video-export/issues."
+-->
+
+### Describe the solution you'd like
+
+<!--
+  Provide a clear and concise description of what you want to happen.
+-->
+
+### Additional context
+
+<!--
+  Is there anything else you can add about the proposal?
+  You might want to link to related issues here, if you haven't already.
+-->
+
+### Contribution
+
+<!--
+  Are you able to create a PR (Pull Request) for this?
+-->
diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml
@@ -0,0 +1,5 @@
+blank_issues_enabled: false
+contact_links:
+  - name: 🙋 Ask a question on Discord! (or Reddit!) 
+    url: https://discord.com/invite/pVVrrxd
+    about: Check if your question has been answered on the [FAQ](https://github.com/oyvindln/vhs-decode/wiki/FAQ) or create a new question.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -6,9 +6,9 @@ on:
   release:
 
 jobs:
-  tests:
-    name: Build and test
-    runs-on: ubuntu-20.04
+  qt5:
+    name: Build with Qt 5
+    runs-on: ubuntu-22.04
     steps:
 
     - uses: actions/checkout@v2
@@ -22,82 +22,67 @@ jobs:
       timeout-minutes: 10
       run: |
         sudo apt-get update
-        # This list is from: https://github.com/happycube/ld-decode/wiki/Installation
-        sudo apt-get install -y --no-install-recommends clang libfann-dev python3-numpy python3-scipy python3-matplotlib git qt5-default libqwt-qt5-dev libfftw3-dev python3-tk python3-pandas python3-numba libavformat-dev libavcodec-dev libavutil-dev ffmpeg openssl pv
+        # Based on: https://github.com/happycube/ld-decode/wiki/Installation
+        # Added: cmake libqt5opengl5-dev libqt5svg5-dev
+        sudo apt-get install -y --no-install-recommends git cmake make python3-setuptools python3-numpy python3-scipy python3-matplotlib git libqt5opengl5-dev libqt5svg5-dev libqwt-qt5-dev libfftw3-dev python3-numba libavformat-dev libavcodec-dev libavutil-dev ffmpeg
+
+    - name: Set up build dir
+      timeout-minutes: 1
+      run: mkdir obj && ln -s ../testdata obj/testdata
+
+    - name: Configure
+      timeout-minutes: 5
+      run: cd obj && cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DUSE_QT_VERSION=5 ..
 
     - name: Build
       timeout-minutes: 15
-      run: make prefix=/usr
+      run: make -C obj VERBOSE=1
 
     - name: Install
       timeout-minutes: 5
-      run: make install prefix=/usr DESTDIR=/tmp/staging
-
-    - name: Run testfilter
-      timeout-minutes: 5
-      run: tools/library/filter/testfilter/testfilter
+      run: make -C obj install DESTDIR=/tmp/staging && ls -lR /tmp/staging
 
-    - name: Run testvbidecoder
-      timeout-minutes: 5
-      run: tools/library/tbc/testvbidecoder/testvbidecoder
-
-    - name: Test ld-cut (NTSC)
-      timeout-minutes: 10
-      run: |
-        scripts/test-decode \
-          --cut-seek 30255 \
-          --cut-length 4 \
-          --expect-frames 4 \
-          --expect-vbi 9151563,15925845,15925845 \
-          testdata/ve-snw-cut.lds
-    
-    - name: Test ld-cut (PAL)
-      timeout-minutes: 10
-      run: |
-        scripts/test-decode \
-          --pal \
-          --cut-seek 760 \
-          --cut-length 4 \
-          --expect-frames 4 \
-          --expect-vbi 9152512,15730528,15730528 \
-          testdata/pal/ggv-mb-1khz.ldf
-
-    - name: Decode NTSC CAV
-      timeout-minutes: 10
-      run: |
-        scripts/test-decode \
-          --decoder mono --decoder ntsc2d --decoder ntsc3d \
-          --expect-frames 29 \
-          --expect-bpsnr 43.3 \
-          --expect-vbi 9151563,15925840,15925840 \
-          --expect-efm-samples 40572 \
-          testdata/ve-snw-cut.lds
-
-    - name: Decode NTSC CLV
+    - name: Run tests
       timeout-minutes: 10
-      run: |
-        scripts/test-decode \
-          --expect-frames 4 \
-          --expect-bpsnr 37.6 \
-          --expect-vbi 9167913,15785241,15785241 \
-          testdata/issues/176/issue176.lds
+      run: cd obj && ctest --output-on-failure
 
-    - name: Decode PAL CAV
+  qt6:
+    # XXX This builds without Qwt as Ubuntu 22.04 doesn't have it for Qt 6
+    name: Build with Qt 6
+    runs-on: ubuntu-22.04
+    steps:
+
+    - uses: actions/checkout@v2
+
+    - uses: actions/checkout@v2
+      with:
+        repository: happycube/ld-decode-testdata
+        path: testdata
+
+    - name: Install dependencies
       timeout-minutes: 10
       run: |
-        scripts/test-decode --pal \
-          --decoder mono --decoder pal2d --decoder transform2d --decoder transform3d \
-          --expect-frames 4 \
-          --expect-bpsnr 38.4 \
-          --expect-vbi 9151527,16065688,16065688 \
-          --expect-efm-samples 5292 \
-          testdata/pal/jason-testpattern.lds
-
-    - name: Decode PAL CLV
+        sudo apt-get update
+        # Based on: https://github.com/happycube/ld-decode/wiki/Installation
+        # Added: cmake qt6-base-dev libgl-dev (needed by QtGui)
+        sudo apt-get install -y --no-install-recommends git cmake make python3-setuptools python3-numpy python3-scipy python3-matplotlib qt6-base-dev libgl-dev libfftw3-dev python3-numba libavformat-dev libavcodec-dev libavutil-dev ffmpeg
+
+    - name: Set up build dir
+      timeout-minutes: 1
+      run: mkdir obj && ln -s ../testdata obj/testdata
+
+    - name: Configure
+      timeout-minutes: 5
+      run: cd obj && cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DUSE_QT_VERSION=6 -DUSE_QWT=OFF ..
+
+    - name: Build
+      timeout-minutes: 15
+      run: make -C obj VERBOSE=1
+
+    - name: Install
+      timeout-minutes: 5
+      run: make -C obj install DESTDIR=/tmp/staging && ls -lR /tmp/staging
+
+    - name: Run tests
       timeout-minutes: 10
-      run: |
-        scripts/test-decode --pal --no-efm \
-          --expect-frames 9 \
-          --expect-bpsnr 30.3 \
-          --expect-vbi 0,8449774,8449774 \
-          testdata/pal/kagemusha-leadout-cbar.ldf
+      run: cd obj && ctest --output-on-failure
diff --git a/.gitignore b/.gitignore
@@ -7,9 +7,10 @@ scipy
 
 # Python build results
 /MANIFEST
-__pycache__
 /build
 /dist
+/python-build
+__pycache__
 
 # Prerequisites
 *.d
@@ -19,39 +20,65 @@ __pycache__
 *.s
 
 # Compiled Object files
-*.slo
 *.lo
 *.o
 *.obj
+*.slo
 
 # Precompiled Headers
 *.gch
 *.pch
 
 # Compiled Dynamic libraries
-*.so
-*.dylib
 *.dll
+*.dylib
+*.so
 
 # Fortran module files
 *.mod
 *.smod
 
 # Compiled Static libraries
-*.lai
-*.la
 *.a
+*.la
+*.lai
 *.lib
 
 # Executables
+*.app
 *.exe
 *.out
-*.app
 
 # ld-decode data files
 *.tbc
+testdata
 testout
 
 # Profiling results
-perf.data*
 Benchfile*
+perf.data*
+
+# CMake related things
+*-qt/
+*.depends
+*.ninja
+*_autogen/
+.ninja_*
+.qt/
+CMakeCache.txt
+CMakeFiles/
+CMakeLists.txt.user
+CTestTestfile.cmake
+DartConfiguration.tcl
+Makefile
+Testing/
+build-*/
+cmake_install.cmake
+install_manifest.txt
+moc_*.cpp
+moc_*.cpp_parameters
+ui_*.h
+
+# vscode related thingss
+.vscode/
+.theia/