Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--quiet no longer functional #427

Closed
Gamnn opened this issue Jan 25, 2020 · 4 comments
Closed

--quiet no longer functional #427

Gamnn opened this issue Jan 25, 2020 · 4 comments
Labels
bug ld-decode-tools An issue only affecting the ld-decode-tools

Comments

@Gamnn
Copy link
Contributor

Gamnn commented Jan 25, 2020

The change in logging seems to have broken the --quiet (-q) option in ld-chroma-decoder. This is probably a good time to see about adding it to ld-dropout-correct and any other tools that might be in a pipe as well.
@atsampson
Copy link
Collaborator

It'd be possible to move the option parsing into the library as well, so all the tools had the same set of logging options...

@simoninns simoninns added bug ld-decode-tools An issue only affecting the ld-decode-tools labels Jan 25, 2020
@simoninns
Copy link
Collaborator

Regression caused by fix for issue #410

simoninns pushed a commit that referenced this issue Jan 25, 2020
Fix for issue #427
ac9b9c7
@simoninns
Copy link
Collaborator

Added issue #429 for the suggestion by @atsampson as it's an enhancement. For now I'll just fix the regression.

simoninns pushed a commit that referenced this issue Jan 25, 2020
Merge pull request #430 from happycube/issue-427
050a36b 
Fix for issue #427
@simoninns
Copy link
Collaborator

Issue fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ld-decode-tools An issue only affecting the ld-decode-tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atsampson @simoninns @Gamnn