Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTSC framing #462

Closed
Gamnn opened this issue Feb 13, 2020 · 1 comment
Closed

NTSC framing #462

Gamnn opened this issue Feb 13, 2020 · 1 comment
Labels
ld-decode An issue only affecting the ld-decode[r]

Comments

@Gamnn
Copy link
Contributor

Gamnn commented Feb 13, 2020

For most of my sources, it seems to set the start and end as follows:

  "activeVideoStart": 134,
  "activeVideoEnd": 887,

Which comes out to 753 width. This often cuts off the right side of the picture and pads it with black to meet 760 width. Ideally, it should set the activeVideoEnd to (activeVideoStart + 760), unless (activeVideoStart + 760) > fieldWidth
@simoninns simoninns added the ld-decode An issue only affecting the ld-decode[r] label Feb 17, 2020
happycube added a commit that referenced this issue Feb 17, 2020
@happycube
Merge pull request #464 from Gamnn/patch-1
48a88a1 
crack at #462
@Gamnn
Copy link
Contributor Author

Gamnn commented Feb 17, 2020

Solved with 5f2eb48.

@Gamnn Gamnn closed this as completed Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ld-decode An issue only affecting the ld-decode[r]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simoninns @Gamnn