Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld-discmap eating .pcm files #557

Closed
Gamnn opened this issue Sep 22, 2020 · 1 comment
Closed

ld-discmap eating .pcm files #557

Gamnn opened this issue Sep 22, 2020 · 1 comment
Labels
bug ld-decode-tools An issue only affecting the ld-decode-tools
Milestone

Comments

@Gamnn
Copy link
Contributor

Gamnn commented Sep 22, 2020

When I run ld-discmap I get the following, then the 317.5 MB input pcm file is overwritten with a 0 byte file.

ld-discmap r.tbc r.mapped.tbc -d
Debug: Version - Git branch: master / commit: b698e59
Info: LaserDisc mapping tool
Info: 
Info: Please note that disc mapping is not fool-proof - if you
Info: have a disc that does not map correctly run ld-discmap
Info: with the --debug option for more details about the process
Info: (and the additional information required for issue reporting
Info: to the ld-decode project).
Info: 
Info: Some early LaserDiscs do not provide frame numbering or
Info: time-code information and cannot be automatically mapped -
Info: if in doubt verify your source TBC file using the ld-analyse
Info: application.
Info: 
Info: Note that NTSC CAV pulldown support currently only handles
Info: discs that follow the standard 1-in-5 pulldown pattern.
Info: 
Info: Processing input metadata for r.tbc
Debug: LdDecodeMetaData::read(): Loading JSON file "r.tbc.json"
Debug: Checking first 100 sequential frames for disc CAV/CLV type determination
Debug: Got 100 valid CAV picture numbers from 100 frames - source disc type is CAV
Debug: Storing VBI CAV picture numbers as frame numbers
Debug: Disc type is NTSC CAV - checking for pull-down frames
Debug: Performing a frame quality analysis for each frame
Debug: DiscMap(Frames 53941, disc type is CAV, video format is NTSC, detected 0 pulldown frames)
Info: Input TBC is CAV NTSC
Info: Checking for lead in and out frames...
Info: Removing 1 frames marked as lead in/out
Info: Removing invalid frames by phase analysis...
Info: Removing 0 frames marked as invalid due to incorrect phase sequence
Info: Correcting frame numbers using sequence analysis...
Info: Sequence analysis corrected 0 frame numbers
Info: Searching for duplicate frames
Debug: Building list of VBIs that have more than one entry in the discmap...
Debug: Sorting the duplicated frame list into numerical order...
Debug: Removing any repeated frame numbers from the duplicated frame list...
Debug: Found 0 VBI frame numbers with more than 1 entry in the discmap
Info: Removed 0 duplicate frames - disc map size now 53940 frames
Info: Numbering pulldown frames in the disc map...
Info: Numbering complete
Info: Verifying frame numbers are present for all frames in the disc map...
Info: Verification successful
Info: Sorting the disc map into numerical frame order...
Info: Sorting complete
Info: Looking for sequence gaps to pad in the disc map...
Info: No gaps found in the disc map
Info: After padding the disc map contains 53940 frames
Info: Searching disc map for pulldown frames...
Info: Search complete; no pulldown frames present
Info: Disc mapping process completed
Info: Writing output video and metadata information...
Debug: SourceVideo::open(): Called with field byte length = 478660
Debug: SourceVideo::open(): Successful - 107882 fields available
Debug: Opening audio source metadata for sample analysis...
Debug: LdDecodeMetaData::read(): Loading JSON file "r.tbc.json"
Debug: Opened audio source; processing field sample lengths...
Info: Saving target video frames...
Fatal: Could not get enough input bytes from input audio file
Aborted (core dumped)
@simoninns simoninns added bug ld-decode-tools An issue only affecting the ld-decode-tools labels Sep 22, 2020
@simoninns simoninns added this to the Revision 7 milestone Sep 22, 2020
simoninns added a commit that referenced this issue Dec 2, 2020
simoninns added a commit that referenced this issue Dec 2, 2020
@simoninns
Copy link
Collaborator

Fixed in latest commit. There was an error with the filename forming code. I also added an additional check to ensure the target audio file doesn't exist before overwriting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ld-decode-tools An issue only affecting the ld-decode-tools
Projects
None yet
Development

No branches or pull requests

2 participants