Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAL - Dropouts outside possible range #654

Closed
IanSmallshire opened this issue Sep 11, 2021 · 4 comments
Closed

PAL - Dropouts outside possible range #654

IanSmallshire opened this issue Sep 11, 2021 · 4 comments
Labels
bug ld-decode An issue only affecting the ld-decode[r]

Comments

@IanSmallshire
Copy link
Collaborator

IanSmallshire commented Sep 11, 2021

Tested over multiple samples

When plotting the extents of Start / End within a line and also the line numbers I have identified these:

  • negative video line numbers for dropouts
  • PAL + NTSC max dropout start is after max dropout end (thought they were cut at the end of a line)
  • Without negative lines 0-313 is is 314 inclusive which is higher than 0-312 expected (625/2 = 312.5 rounded up for half line)

image

@happycube
Copy link
Owner

@oyvindln has a fixed version already, going to merge it into my current working branch and then merge it up:

https://github.com/oyvindln/ld-decode/blob/vhs_decode/vhsdecode/doc.py#L136

@simoninns simoninns added bug ld-decode An issue only affecting the ld-decode[r] labels Dec 12, 2021
@happycube
Copy link
Owner

I merged above in a while ago, need to check to see if it's fixed.

@happycube
Copy link
Owner

Making another change to dropout detection - if I got it right, it'll block out any off-field dropouts from being seen at all.

happycube added a commit that referenced this issue Jan 30, 2022
#649/#654: filter out dropout detection outside of actual field
@happycube
Copy link
Owner

(feel free to reopen if I didn't fix it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ld-decode An issue only affecting the ld-decode[r]
Projects
None yet
Development

No branches or pull requests

3 participants