Make the top-level Makefile build/install all of ld-decode #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no standard for this in qmake, but PREFIX seems to be a common name in other projects.
This tries to cover building and installation for typical users, and supports GNU-style prefix and DESTDIR variables for installing in custom prefixes and package staging dirs. Variables are provided to override qmake and python3 because some systems have different names for these (qmake-5, python3.7, ...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The effect of this is that the installation instructions for ld-decode can be simplified to something like:
make -j8(or however many CPUs you have)sudo make installYou can also specify
prefix=/whereverto install into a different prefix, and you can specifyprefix=/usr DESTDIR=/somewhere/elseas usual to install into a staging area when building distribution packages. The CI does aDESTDIRinstallation to check it all basically works.Make's default
CCis used to build ld-ldf-reader, so clang can be removed from the list of dependencies (you can still setCC=clangif you prefer). Variables are provided for qmake and python3 since some distributions name these differently.