Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for VbiDecoder #396

Merged
merged 6 commits into from
Jan 2, 2020
Merged

Add unit tests for VbiDecoder #396

merged 6 commits into from
Jan 2, 2020

Commits on Jan 1, 2020

  1. Move default values for VbiDecoder::Vbi into the struct definition.

    @atsampson
    atsampson committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    9eca95a View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Don't assume CAV/CLV until we actually see a code. 

    For example, a field containing only lead-out codes shouldn't be
reported as either CAV or CLV.
    @atsampson
    atsampson committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    01d3d17 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for VbiDecoder. 

    This includes some tests (#if 0-d out) that don't currently pass.
    @atsampson
    atsampson committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    d3ee284 View commit details
    Browse the repository at this point in the history

  3. Fix VBI parity check. 

    A copy-and-paste error meant that parity wasn't being checked correctly
for two of the X5 bits.
    @atsampson
    atsampson committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    e2a1a0d View commit details
    Browse the repository at this point in the history

  4. Use a helper function for validated BCD decoding. 

    This means that all the VBI codes that use BCD now check whether all the
digits are valid.
    @atsampson
    atsampson committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    0ae4693 View commit details
    Browse the repository at this point in the history

  5. Don't store invalid user codes.

    @atsampson
    atsampson committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    82e2971 View commit details
    Browse the repository at this point in the history