Add ld-export-metadata #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsampson
added
enhancement
ld-decode-tools
|
Review question: I put the FFMETADATA1 code in ld-export-metadata, because it's a bit too complex (and magical) to be an LdDecodeMetaData method. Should the other two existing export modes be the same? Or should they all be in, say, library/tbc/export.cpp...? |
|
I'm not a big fan of duplicating functionality :) I also think a separate tool is the better approach to metadata export. I'd be happy if both export functions in the metadata library were removed and placed in the ld-export-metadata app locally. Then both functions can be removed from the library and ld-analyse as they will not be required. |
To start with, this provides a command-line interface to LdDecodeMetaData's existing CSV export methods.
Simon suggested that it'd be better to have this in the export tool.
You can feed the output of this into ffmpeg, to produce (for example) Matroska output with chapter markers. Stop codes are just listed as comments at the moment. This is a straight translation of my decode-vbi Python program.
atsampson
force-pushed
the
exportmetadata
branch
from
a67d162
to
cd4fb00
Compare
|
This now moves all the export code into ld-export-metadata, and removes the ld-analyse GUI bits for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new command-line tool for converting information from the JSON file into formats that other tools can understand. At present, it can do:
I've tested FFMETADATA1 export against all the decoded discs I had around, and it seems to produce reasonable results for anything that has chapters.
Exporting CC subtitles as SRT would be a useful future extension.