Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VideoParameters::first/lastActiveFrameLine directly in more places #446

Merged
merged 4 commits into from
Jan 27, 2020
Merged

Use VideoParameters::first/lastActiveFrameLine directly in more places #446

merged 4 commits into from
Jan 27, 2020

Commits on Jan 27, 2020

  1. Use first/lastActiveFrameLine directly in ld-chroma-decoder. 

    Because VideoParameters used to only contain the horizontal active
region bounds, several ld-chroma-decoder classes used to maintain their
own idea of the vertical bounds. Now that VideoParameters contains the
vertical bounds, this isn't needed any more.

SourceField's helpers to compute field lines are still needed because
the active lines can be different for the two fields.
    @atsampson
    atsampson committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    971ad6d View commit details
    Browse the repository at this point in the history

  2. Remove unused member variable.

    @atsampson
    atsampson committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    afdfd8e View commit details
    Browse the repository at this point in the history

  3. Pass more arguments as const references. 

    For findPotentialReplacementLine, reorder the arguments to keep the
output at the end.
    @atsampson
    atsampson committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    ff8269b View commit details
    Browse the repository at this point in the history

  4. Use first/lastActiveFrameLine directly in ld-dropout-correct.

    @atsampson
    atsampson committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    a4c8110 View commit details
    Browse the repository at this point in the history