Initial support for subcarrier-locked sampling. #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsampson
added
enhancement
ld-decode-tools
For 4fSC subcarrier-locked PAL, the TBC file contains four more samples than usual over the course of 625 lines, so the two fields are horizontally misaligned by two samples. This shifts the second field to the left to compensate. This is only an initial fix for now, since the same problem will apply to ld-dropout-correct and the other tools -- it really needs dealing with in the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 4fSC subcarrier-locked PAL, the TBC file contains four more samples than usual over the course of 625 lines, so the two fields are horizontally misaligned by two samples (see discussion in #242). This shifts the second field to the left to compensate.
This is only an initial fix for now, since the same problem will apply to ld-dropout-correct and the other tools -- it really needs dealing with in the library.
No change for existing files; it's only enabled if the video parameters contain
isSubcarrierLocked: true.