Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVideoField: when seeking forward isn't possible, try reading and discarding #473

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

atsampson
Copy link
Collaborator

When SourceVideo::getVideoField is reading video from an unseekable source, like a pipe, trying to seek forward to a field later in the file would fail -- which, for example, means you couldn't use "ld-chroma-decoder -s" when input was from a pipe.

Make it try to read and discard data instead when seeking forward fails. If reading fails or hits the end of the input stream, it'll report an error as before.

When SourceVideo::getVideoField is reading video from an unseekable
source, like a pipe, trying to seek forward to a field later in the file
would fail -- which, for example, means you couldn't use
"ld-chroma-decoder -s" when input was from a pipe.

Make it try to read and discard data instead when seeking forward fails.
If reading fails or hits the end of the input stream, it'll report an
error as before.
@atsampson atsampson added enhancement ld-decode-tools An issue only affecting the ld-decode-tools labels Mar 8, 2020
@atsampson atsampson requested a review from simoninns March 8, 2020 21:42
@simoninns simoninns merged commit 2ee735a into happycube:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ld-decode-tools An issue only affecting the ld-decode-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants