Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple PAL UV filter and PAL encoder enhancements #476

Merged
merged 10 commits into from
Mar 23, 2020

Commits on Mar 21, 2020

  1. Configuration menu
    Copy the full SHA
    517b90d View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Configuration menu
    Copy the full SHA
    e1bbaa0 View commit details
    Browse the repository at this point in the history
  2. Remove the horizontal tile bounds checks.

    The second assert trips with EBU Tech 3280-style sample layout, where
    the digital active area runs right up to the end of the line. It's not
    actually a problem to run off the end of the line, because we'll just be
    using the blanking data from the start of the next line (and there's
    always another line after the last active line).
    atsampson committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    2d063a2 View commit details
    Browse the repository at this point in the history
  3. Add ld-chroma-decoder --simple-pal for a 1D UV filter.

    This gives better vertical resolution, at the cost of not dealing with
    chroma phase errors. Thanks to Richard Russell for providing the specs
    for the filter from the BBC's original Transform PAL implementation.
    
    This only works with transform2d/3d at the moment, but in the future
    it'd be possible to add a luma notch filter, giving a pal1d mode.
    atsampson committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    8da13fd View commit details
    Browse the repository at this point in the history
  4. Add ld-chroma-encoder --sc-locked for 4fSC subcarrier-locked output.

    The core of this is effectively the same, once the setup is done; it
    just needs to keep track of where 0H is for each line.
    atsampson committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    d2fa901 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    20848dd View commit details
    Browse the repository at this point in the history
  6. Fix prevLines count.

    The count of lines in field 1 was wrong here, which meant that the Vsw
    state didn't flip between the last line of field 1 and the first of
    field 2.
    atsampson committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    f45000f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7cb4b90 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1f5f9c3 View commit details
    Browse the repository at this point in the history
  9. Use Gaussian UV filter, as in pyctools-pal.

    Add a reference to Clarke for the intended characteristic.
    atsampson committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    2da412f View commit details
    Browse the repository at this point in the history