Fix some miscellaneous warnings #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some warnings with GCC 9 -pedantic.
This avoids a runtime warning with numba 0.49. Depending on how the "experiment" proceeds we may need to find a different way of doing this...
Most of these were simply unused variables from the original example, but audio_dst_file was opened as /dev/null and nothing was written to it, so that's not needed either.
Clang 10 correctly warns that "ire > 200 || ire < 65535" is always true; from the comment above, this should be &&.
atsampson
added
ld-decode-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested the diffdod change, but it looks correct from the comment above.