Show the current chroma decoder's output on the ld-analyse scope #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used in all the places where the image cache is invalidated, rather than having two different variables.
This avoids fetching the metadata for each field twice, so it's a bit faster overall (although jsonwax is still very, very slow). Also avoid calling getNumberOfFrames for each iteration of the loop.
Previously all the methods that got data from TbcSource took a frame number as an argument, which meant they all had to load frame metadata individually. There's now a loadFrame method that you call when the current frame changes (which only happens in one place in ld-analyse), and this caches the metadata for the other methods to use directly. The chapter search methods still take a frame number because they're only searching the chapter map.
This was the same in the constructor and when loading a new file, and it would make sense to do this when closing a file as well.
This means we don't need to load the source fields again when drawing charts. As before, we still reload the source fields whenever the decoder parameters are changed. This could be avoided by looking to see whether the amount of lookbehind/ahead has actually changed or not, but the performance impact probably doesn't make it worthwhile.
More specifically, show the chroma decoder's luma output as the Y trace, and the difference between that and the composite signal as the C trace. This is not quite correct, but it's close enough for most purposes -- resynthesising the actual C signal from the UV output would require us to know the chroma phase for each line as well. Since the chroma decoder's output is only meaningful in the active region, clip the Y/C traces to the active region both horizontally and vertically (previously they started at the end of the colourburst).
atsampson
added
enhancement
ld-decode-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces ld-analyse's old 1D filters, and it means that you can see the effect of chroma decoder configuration changes - including noise reduction - interactively on the scope.
I've refactored
TbcSourceas part of this - it now acts more like a player that you can seek to a particular frame, so the decoder and the different analysis views all use the same cached data. The same infrastructure should make it fairly straightforward to add a vectorscope or other kinds of displays.Fixes #305.