Fixes for tools to build on windows (MSVC) #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use std::vector instead of VLA (VLA is non-standard C++, gcc has it as an extension, MSVC does not) Add define so M_PI is defined Specify linking to qwt on windows (may need to fix naming if we ever want to compile with mingw)
(Only actual change was removing a non-standard preprocessor directive unavailable on MSVC)
|
WIth this the tools now build with MSVC on windows. I haven't ran the tests etc yet though, need to add some stuff to bundle dlls and/or build statically. Running ld-analyse from qt creator and opening tbcs seems to work with no issues at least. What I did to build was to install MS build tools 2019 for the compiler, Qt for qt creator, and Then create a new Qt kit with qmake from vcpkg in qt creator, and add this: |
atsampson
reviewed
Oct 9, 2021
atsampson
reviewed
Oct 9, 2021
|
btw the removal of the GPL header from some of the EZPWD source files was from upstream, no idea why they did that but it's still GPL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable-length arrays are non-standard, so replaced it with vectors instead. Not sure if it was ideal to use that for arrays that large anyhow. They're currently re-created on every call to those functions which is a bit sub-optimal but not focusing on that right now.