New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid get_git_info failing if commands fail and add two checks to avoid mean of empty slice warning #693

Merged

happycube merged 1 commit into happycube:master from oyvindln:upstream_fix

Jan 26, 2022

Contributor

oyvindln commented Jan 26, 2022

get_git_version can fail since branch/commit are not initialized in all branches.

the version file also doesn't have a ":" in it, so not sure what the intention was there.


          Avoid get_git_info failing if commands fail and add two checks to avo…

ac8211e

…id mean of empty slice warning

happycube approved these changes

View reviewed changes

Owner

happycube left a comment

Didn't think of the fallback (oops), and that empty slice warning's annoying too. Thanks!

happycube merged commit a0d58eb into happycube:master

oyvindln deleted the upstream_fix branch

June 4, 2022 14:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet