Support multiple video systems, and add PAL-M support #728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @oyvindln, who kindly supplied a sample PAL-M VHS capture to test this with...
In the JSON,
isSourcePal
is replaced by a"system"
string. In the library, this is converted to aVideoSystem
enum; if"system"
is not set, then the system is guessed fromisSourcePal
andfieldHeight
, so the tools will still work with old files.PAL-M uses PAL colour on a 525-line line standard with fSC being close to but not the same as NTSC -- so in some senses it works like standard PAL, and in some senses like standard NTSC. Adjust all the system-dependent parts of the tools as needed, including filters.
To make testing this easier, it also adds better support for vhs-decode's separate
_chroma.tbc
files in ld-analyse - it now loads both files if present, and lets you switch between Y, C or Y+C:(Note to self to update the JSON docs again if people are happy with this.)