Fix building with cmake on windows #806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither qwt nor pkg-config seems to include a .pc file on windows, so this borrows a findQwt script from QGis to make handling it easier.
The other addition needed was to define
_USE_MATH_DEFINES
asM_PI
is a non-standard extension and as such not available from<cmath>
when compiling with MSVC otherwise.Now builds with cmake+msbuild on windows if the needed packages are installed via vcpkg and using the ms dev environment command line and vcpkg cmake toolchain file.
ld-ldf-reader is still disabled for windows as it uses some linux/unix-specific functions, also disable it for macos as @kaliohelix on discord reported it didn't build properly there either.