Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configuration warning #24

Merged
merged 5 commits into from
Jul 4, 2022
Merged

fix configuration warning #24

merged 5 commits into from
Jul 4, 2022

Conversation

dferber90
Copy link
Contributor

@dferber90 dferber90 commented Feb 5, 2022

As config was an export, the value seen by imports was never updated, even after reconfiguring, as imported values are not live.

This is fixed by introducing a getter.

I believe this only happened for people not using swc, but I did not dig into it.

The fix for users here is to upgrade to v2.0.6 which I'll release in a bit.

relates to #23

@vercel
Copy link

vercel bot commented Feb 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/happykit/flags/FxdoZGaUsbZUK4tDv2sRa51bKJXz
✅ Preview: Failed

@dferber90 dferber90 changed the title Config export fix configuration warning Feb 5, 2022
@vercel
Copy link

vercel bot commented Jul 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flags ✅ Ready (Inspect) Visit Preview Jul 4, 2022 at 7:16AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant