added save version 61.5 compatibility #104
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Save-Version 61.5 compatibility for the fast header+body parser.
This patch is running since a few hours for us now, we could parse hundreds of games with it.
But i have to mention two things which i'm not happy with for now:
Finding Marker at scenario parsing
Although this works i couldn't find a way to do it without this marker (as it was before). I think there might be better ways to do it.
Unit tests
The different parser implementations support different versions, the fast header parser doesn't seem to support DE save-versions <=13 (at least it didn't at my tests, and i couldn't find the conditional parsings for versions like 13.17 as in the full parser, for example).
And since i've now added unit tests for the fast header parser i had to add some ugly guard checks to skip some savegames in some conditions.
Maybe it would be better to group the savegames in different folders or smth. like that.
If you already work on your own implementation just skip this pr and we will fetch your upstream changes as soon as they are available.