Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonJS support #257

Merged
merged 1 commit into from
Nov 20, 2014
Merged

CommonJS support #257

merged 1 commit into from
Nov 20, 2014

Conversation

nervo
Copy link
Contributor

@nervo nervo commented Nov 17, 2014

No description provided.

@thepag
Copy link
Contributor

thepag commented Nov 19, 2014

I take it that exports is a global var in commonJS, like define is with AMD?
I'll be reviewing that, and only ask since I'll need to add that to the jshint options.

@nervo
Copy link
Contributor Author

nervo commented Nov 19, 2014

Something like that, yes.
Have a look on this https://github.com/umdjs/umd

thepag added a commit that referenced this pull request Nov 19, 2014
@thepag
Copy link
Contributor

thepag commented Nov 19, 2014

You need to sign the CLA please.

@thepag
Copy link
Contributor

thepag commented Nov 19, 2014

Yeah, I looked into it and added the require global to the .jshintrc list of globals.

@thepag thepag merged commit 6fe1d3b into jplayer:master Nov 20, 2014
@thormeier
Copy link
Contributor

Thanks for merging! Already installed 2.9 via composer :)
By the way, have you considered registering jPlayer on https://packagist.org/ as suggested in the initial PR?

@thepag
Copy link
Contributor

thepag commented Nov 28, 2014

I think you mean PR #235 @thormeier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants