-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer support #235
Composer support #235
Conversation
I'd be happy if someone could give some feedback on this one whether it does make sense or not. |
+1, I think jplayer should have composer support. Hope it will be merged. |
+1, now composer is a standar for php developers |
Hello @thormeier would you please sign the CLA and I will look into merging this PR. I'll need to check that my structural changes to the repo have not broken your composer config files... I suspect that it will break your personal composer install though when you update. I made a rather large error with the versioning system in the repository that affects bower and probably would affect this too. But you sign the CLA, and I should be able to correct the paths and such while performing the merge. Otherwise, I'll be sure to ask here for some help. |
Hi @thepag, |
Also, I'm moving the requiring of JQuery to a suggestion part, since one would not want to force devs to use the component version if they already have a CDN version or similar installed. Will make the last changes in about 2 hours, if that is ok. |
Thanks. I'll be looking at this tomorrow now. I did a round of merges today that I'd call patches. This is technically "new feature" and will go into dev branch ready for 2.9. I intent to get 2.9 out soon though. |
Added more information and moved jquery to suggests
Updated |
Cheers for updating the config. This path here looks obsolete Doing this one next. |
This PR has been merged into the dev branch. I corrected the script and file paths, since they were obsolete. Review the dev branch to see it. This PR will auto-close when dev gets merged with master. |
Done. I notice that someone else registered a jPlayer (fork?) under components/jPlayer. |
I'm adding a link to the download page... Is this appropriate terminology? |
Yes, it is, thank you very much! Also you can remove the |
This PR adds support for installing jPlayer via composer to simply install and use it and keep it updated in Symfony2 applications and other projects that use composer.
Also added a short installation guide for now. If you merge this, you might want to register jPlayer on Packagist to get rid of the
"repositories": {}
part that is currently needed to install it.