Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEDIUM: runtime: Add glitch metrics to stick table fields #114

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Kilobyte22
Copy link

HAProxy recently added a new sticktable counter for "glitches". This PR adds support for those to the library.

If any changes are desired for inclusions in upstream (in particular in regards to style), I am happy to apply them

@mjuraga
Copy link
Collaborator

mjuraga commented Jan 27, 2025

Thank you for your contribution. We can include this in the upstream, Can you just change the commit message to match our contributing guidelines. e.g. MEDIUM: runtime: Add glitch metrics to stick table fields.

Also rebasing the PR would help us.

@Kilobyte22 Kilobyte22 force-pushed the sth-glitchcount branch 2 times, most recently from 48d752f to 0322ca6 Compare January 27, 2025 14:40
@Kilobyte22 Kilobyte22 changed the title feat: Add glitch metrics to stick table fields MEDIUM: runtime: Add glitch metrics to stick table fields Jan 27, 2025
@Kilobyte22
Copy link
Author

I have rebased my change and changed both commit and MR title to match the style guide.

@mjuraga mjuraga merged commit 89941e9 into haproxytech:master Jan 28, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants