remove node 12 support yml

bump eslint ecmaVersion to 20

lint

.eslintrc.yaml

@@ -6,7 +6,7 @@ parserOptions:
   #ecmaVersion: 2015 (6)
   #ecmaVersion: 2016 (7) (node 6)
   #ecmaVersion: 2017 (8) (node 8)
-  ecmaVersion: 2017
+  ecmaVersion: 2020
   #ecmaVersion: 2018 (9) (node 10)
   #ecmaVersion: 2019 (10) (node 12)
   #ecmaVersion: 2020 (11) (node 14)

.github/workflows/ci-test-win.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       matrix:
         os: [ windows-latest ]
-        node-version: [12.x, 14.x]
+        node-version: [14.x]
       fail-fast: false
 
     steps:

.github/workflows/ci-test.yml

@@ -18,7 +18,8 @@ jobs:
         # node 6, maint. ended 2018-04
         # node 8, maint. ended 2019-12
         # node 10, maint. ends 2021-04
-        node-version: [12.x, 14.x]
+        # node 12, maint. ends 2022-04
+        node-version: [14.x]
       fail-fast: false
 
     steps:

.github/workflows/coveralls.yml

@@ -15,10 +15,10 @@ jobs:
       with:
         fetch-depth: 1
 
-    - name: Use Node.js 12
+    - name: Use Node.js 14
       uses: actions/setup-node@master
       with:
-        node-version: 12.x
+        node-version: 14.x
 
     - name: install, run
       run: |

.github/workflows/lint.yml

@@ -10,7 +10,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [ 12.x ]
+        node-version: [ 14.x ]
 
     steps:
     - uses: actions/checkout@v1

plugins/queue/qmail-queue.js

@@ -60,7 +60,6 @@ exports.hook_queue = function (next, connection) {
     qmail_queue.stdin.on('close', () => {
         if (connection?.transaction == null) {
             plugin.logerror("Transaction went away while delivering mail to qmail-queue");
-
             try {
                 qmail_queue.stdout.end();
             }

plugins/spf.js

@@ -308,8 +308,8 @@ exports.return_results = function (next, connection, spf, scope, result, sender)
 exports.save_to_header = (connection, spf, result, mfrom, host, id, ip) => {
     // Add a trace header
     if (connection?.transaction == null) {
-        connection.logwarn(plugin, "save_to_header could not find transaction, returning undefined");
-        return; 
+        connection.logwarn("save_to_header could not find transaction, returning undefined");
+        return;
     }
     const des = result === spf.SPF_PASS ? 'designates' : 'does not designate';
     const identity = `identity=${id}; client-ip=${ip ? ip : connection.remote.ip}`;

smtp_client.js

@@ -281,7 +281,7 @@ class SMTPClient extends events.EventEmitter {
         if (connection?.transaction == null) {
             connection.logwarn(plugin, "transaction went away, releasing smtp_client");
             this.release();
-            return true;    
+            return true;
         }
         return false;
     }