Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use npx in package.json scripts #2729

Merged
merged 7 commits into from
Nov 4, 2019
Merged

use npx in package.json scripts #2729

merged 7 commits into from
Nov 4, 2019

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Nov 4, 2019

Changes

  • package.json: use npx in scripts (works everywhere- locally, GitHub Actions, Travis, AppVeyor)
  • tls_socket: process all entries in config/tls dir. Uses async.map so previous versions would abort after the first error in a TLS cert was encountered. This surfaced in Windows test where initial err aborted processing of tls dir contents.
  • ignore an SPF error (when DNS lookup fails) when testing on Windows

Checklist

  • Changes updated
  • tests updated

@baudehlo
Copy link
Collaborator

baudehlo commented Nov 4, 2019

Is this even necessary? Node adds node_modules/.bin to the PATH anyway, so just eslint on its own should work fine.

@msimerson
Copy link
Member Author

Generally, yes, if one values consistency. Do you want the tests run with the locally installed version of $dep in ./node_modules/.bin or the system installed one in /usr/local/bin or /usr/bin? Which is first in PATH? Is that the same on every platform?

shows up in Win test where initial err aborts processing of tls dir contents
@msimerson
Copy link
Member Author

msimerson commented Nov 4, 2019

Generally, yes, if one values consistency.

I'm going to amend that slightly. I haven't tested this in a couple years. It used to be that the only way to get consistent passing CI tests on both Travis & Appveyor was to fully qualify the paths to the locally installed deps and precede that path with node. Nothing else consistently worked. Since then we have dropped a couple older versions of node.

@msimerson msimerson requested a review from a team November 4, 2019 19:43
@baudehlo baudehlo merged commit 36bbd31 into haraka:master Nov 4, 2019
@msimerson msimerson deleted the npx branch November 4, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants