If the option is set, and to anything but true, we don't advertise th…

[gene-hightower]

…e SMTPUTF8 extension.

Fixes #2868

Changes proposed in this pull request:

Checklist:

• docs updated
• tests updated
• Changes updated

[msimerson]

Hi @gene-hightower , lets try instead making sure it's always defined:

diff --git a/connection.js b/connection.js
index 7a2a27bf..49b205e5 100644
--- a/connection.js
+++ b/connection.js
@@ -90,6 +90,7 @@ class Connection {
 
         this.cfg = config.get('smtp.ini', {
             booleans: [
+                '+main.smtputf8',
                 '+headers.add_received',
                 '+headers.show_version',
                 '+headers.clean_auth_results',

[msimerson]

Related to #2866

[gene-hightower]

Great! Much better idea: how do we get this merged?

[msimerson]

apply that patch to this branch, revert the previous change, and push. Then this PR will have that and I'll merge it

[gene-hightower]

apply that patch to this branch, revert the previous change, and push. Then this PR will have that and I'll merge it

Done. Thanks again for working with me to make this happen.

[msimerson]

Looks good! Did you test locally and verify this works as expected?

[gene-hightower]

Looks good! Did you test locally and verify this works as expected?

Yes, I tested with my application and it works now just like it should. (I tested with true, false, and no value set. I did not test with other random values)