Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spamassassin to return DENYSOFT on errors/timeouts #2967

Merged
merged 13 commits into from
Sep 29, 2021

Conversation

superman20
Copy link
Collaborator

Changes proposed in this pull request:

  • Allow spamassassin to return DENYSOFT on connection errors, connection timeouts, and scan timeouts
  • New configuration options added for each scenario, defaulting to false (honoring existing behavior)

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@superman20
Copy link
Collaborator Author

Any interest in this one, yet? It looks like it would also incidentally address #2939.

@msimerson
Copy link
Member

Sorry, I should have replied earlier. The thing I don't like is that the config option is reject but the action is a deferral. Other plugins (spf, avg) use the keyword defer for this purpose.

@superman20
Copy link
Collaborator Author

I didn't love the naming convention I proposed either, but I was paralleling the ClamAV plugin. I can change to the defer nomenclature if you'd prefer.

@msimerson
Copy link
Member

I was paralleling the ClamAV plugin. I can change to the defer nomenclature if you'd prefer.

In the clamav plugin, reject.virus returns a DENY (5NN), and sometimes reject.error returns a DENY and other times a DENYSOFT (4NN) error. So, the usage in clamav plugin is inconsistent. We want to avoid POLA violations so if the knob results in a deferral, then it should be named as such.

@msimerson
Copy link
Member

The other issue is the log messages like this, "Spam scan error". That's not super helpful when a DSN gets forwarded to the email admin and they're running spamassassin, rspamd, and/or another filtering engine. Better to put something explicit and unique to spamassassin in there, such as: spamd, sa, or spamassassin.

@msimerson msimerson merged commit b9b43e5 into haraka:master Sep 29, 2021
@superman20 superman20 deleted the spamassassin_denysoft branch September 30, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants