-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow spamassassin to return DENYSOFT on errors/timeouts #2967
Conversation
Any interest in this one, yet? It looks like it would also incidentally address #2939. |
Sorry, I should have replied earlier. The thing I don't like is that the config option is |
I didn't love the naming convention I proposed either, but I was paralleling the ClamAV plugin. I can change to the |
In the clamav plugin, reject.virus returns a DENY (5NN), and sometimes reject.error returns a DENY and other times a DENYSOFT (4NN) error. So, the usage in clamav plugin is inconsistent. We want to avoid POLA violations so if the knob results in a deferral, then it should be named as such. |
The other issue is the log messages like this, "Spam scan error". That's not super helpful when a DSN gets forwarded to the email admin and they're running spamassassin, rspamd, and/or another filtering engine. Better to put something explicit and unique to spamassassin in there, such as: spamd, sa, or spamassassin. |
Changes proposed in this pull request:
Checklist: