Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor #22

Merged
merged 6 commits into from
Apr 7, 2019
Merged

Appveyor #22

merged 6 commits into from
Apr 7, 2019

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Apr 7, 2019

Fixes this problem, which occurs when appveyor runs the npm script it drops in ./node_modules/bin/mocha. The mocha script has this description:

/**
 * This tiny wrapper file checks for known node flags and appends them
 * when found, before invoking the "real" _mocha(1) executable.
 */

And results in this when it runs:

> haraka-plugin-fcrdns@1.0.3 test C:\projects\haraka-plugin-fcrdns
18> node node_modules/.bin/mocha
19
20C:\projects\haraka-plugin-fcrdns\node_modules\.bin\mocha:2
21basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
22          ^^^^^^^
23
24SyntaxError: missing ) after argument list
25    at createScript (vm.js:80:10)
26    at Object.runInThisContext (vm.js:139:10)
27    at Module._compile (module.js:617:28)
28    at Object.Module._extensions..js (module.js:664:10)
29    at Module.load (module.js:566:32)
30    at tryModuleLoad (module.js:506:12)
31    at Function.Module._load (module.js:498:3)
32    at Function.Module.runMain (module.js:694:10)
33    at startup (bootstrap_node.js:204:16)
34    at bootstrap_node.js:625:3
35npm ERR! Test failed.  See above for more details.
36

@msimerson msimerson merged commit a33c3ce into master Apr 7, 2019
@msimerson msimerson deleted the appveyor branch April 7, 2019 19:26
@msimerson
Copy link
Member Author

The proper fix for this test breakage was upstream in mocha 6.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant