fix: result retrieval #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimerson
approved these changes
Aug 31, 2020
|
Done. |
msimerson
added a commit
that referenced
this pull request
Sep 1, 2020
* rename connect.geoip -> geoip * fix missing URL in README * add badges * code climate improvements * aggregate results before emitting * compat with eslint 4 (#13) * replace node 4 with node 8 testing (#15) * eslint no-var updates (#17) * fix lookup exception #18 * add tests for latitude 0 (#22) * Replace string concatenations with template literals in geoip plugin (#23) * Fixed issue with missing iso_code * minor code climate updates * v1.0.8: add missing 'c' in iso_code. (#29) * safely access country.iso_code * replace nodeunit with mocha (#37) * test: remove conditionals, they mask breaking changes * es6: use object shorthand * scripts: use npx to run them * fix loop (#42) * add funding * fix: result retrieval (#44) * try/catch city & state lookups (#45) * README: formatting improvements (#46) * replace travis/appveyor with github actions (#47) * update badge urls (#48) * add comment to disabled test
msimerson
added a commit
that referenced
this pull request
Sep 3, 2020
4 tasks
msimerson
added a commit
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the plugin is now separated, the result key has changed.