Implemented Browser tests #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meir017
commented
May 11, 2018
| await Task.Delay(150); | ||
| Assert.Equal(0, disconnectedOriginal); | ||
| Assert.Equal(0, disconnectedRemote1); | ||
| Assert.Equal(1, disconnectedRemote2); |
There was a problem hiding this comment.
something isn't working with the Disconnected event
|
Why are we including |
kblok
requested changes
May 11, 2018
lib/PuppeteerSharp/Browser.cs
Outdated
| @@ -97,6 +100,12 @@ internal void ChangeTarget(Target target) | |||
| return version.product.ToString(); | |||
| } | |||
|
|
|||
| public async Task<string> GetUserAgentAsync() | |||
lib/PuppeteerSharp/Browser.cs
Outdated
| @@ -116,7 +125,6 @@ internal void ChangeTarget(Target target) | |||
| } | |||
|
|
|||
| Disconnect(); | |||
| Closed?.Invoke(this, new EventArgs()); | |||
lib/PuppeteerSharp/Session.cs
Outdated
| @@ -152,7 +148,7 @@ internal void OnMessage(string message) | |||
| } | |||
| } | |||
|
|
|||
| internal void Close() | |||
| internal void OnClose() | |||
There was a problem hiding this comment.
I don't know if I buy this rename 🤔
Meir017
commented
May 11, 2018
| @@ -152,7 +148,7 @@ internal void OnMessage(string message) | |||
| } | |||
| } | |||
|
|
|||
| internal void Close() | |||
| internal void OnClosed() | |||
There was a problem hiding this comment.
When I implemented this catch I thought that we might have errors generated by the client, but Chromium is catching those errors for us
|
If you want to read a little bit about the WebSocket mess go to dotnet/corefx#26429 and https://github.com/dotnet/corefx/issues/26556 I found out that we don't need to filter exceptions if the read fails we need to close and move on. |
|
It's not WIP anymore right @Meir017 ? |
kblok
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #185