Fix deserialization exception when retrieving cookie with PartitionKey set #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for jumping in @AlexCSDev. |
AlexCSDev
force-pushed
the
partitionkey_fix
branch
from
8fa326f to
33e0148
Compare
|
I don't have much experience working with System.Text.Json, but I figured writing JsonConverter for this fix will be a decent solution? I must mention that I did not test writing as I don't have any way of testing that quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point CookieParam.PartitionKey became an object in DevTools protocol. This causes deserialization exception because it is currently defined as a string in puppeteer-sharp. This PR implements necessary changes to fix that.